Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: change CI to debug windows crash #8598

Closed
wants to merge 1 commit into from

Conversation

conradoplg
Copy link
Contributor

This is a temporary PR to debug the windows crash on CI

Motivation

What are the most important goals of the ticket or PR?

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Specifications

Complex Code or Requirements

Solution

Testing

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@github-actions github-actions bot added C-bug Category: This is a bug C-security Category: Security issues C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jun 7, 2024
@conradoplg conradoplg force-pushed the windows-crash-debugging branch 15 times, most recently from 0ae6ed3 to 9f28126 Compare June 11, 2024 20:48
@arya2
Copy link
Contributor

arya2 commented Jun 20, 2024

@conradoplg Could we close this PR now that the issue's been resolved?

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests labels Jun 20, 2024
@conradoplg
Copy link
Contributor Author

@conradoplg Could we close this PR now that the issue's been resolved?

Yep. The CI change is still useful so we can keep the branch around.

@conradoplg conradoplg closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-security Category: Security issues C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants