Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blockchain-scanner): Update documentation for the new zebra-scanner binary #8675

Merged
merged 9 commits into from
Jul 16, 2024
Merged

docs(blockchain-scanner): Update documentation for the new zebra-scanner binary #8675

merged 9 commits into from
Jul 16, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

After we added the zebra-scanner binary the documentation we had to scan went out of date.

Close #8586

Solution

Upgrade documentation.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-docs Area: Documentation A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Jul 13, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner July 13, 2024 17:11
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team July 13, 2024 17:11
arya2
arya2 reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

book/src/user/shielded-scan-grpc-server.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan-grpc-server.md Outdated Show resolved Hide resolved
zebra-scan/src/bin/scanner/main.rs Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Show resolved Hide resolved
book/src/user/shielded-scan.md Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
zebra-scan/src/bin/scanner/main.rs Outdated Show resolved Hide resolved
@oxarbitrage oxarbitrage requested a review from arya2 July 16, 2024 20:08
arya2
arya2 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mergify mergify bot merged commit 61746f2 into main Jul 16, 2024
190 checks passed
@mergify mergify bot deleted the zebra-scan-documentation branch July 16, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees
No one assigned
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-docs Area: Documentation P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation changes for the new zebra-scanner binary
2 participants
@oxarbitrage @arya2