Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Label Names in the Address Book #156

Closed
RealityRipple opened this issue Jul 11, 2019 · 3 comments
Closed

Duplicate Label Names in the Address Book #156

RealityRipple opened this issue Jul 11, 2019 · 3 comments

Comments

@RealityRipple
Copy link

Currently, if you add a new address to your Address Book with the same label as an existing address, the existing address is removed from your Address Book, and the new one takes its place. This seems like it could easily lead to user confusion. I suggest one of three possible better actions:

  1. The system allows multiple addresses with the same label. This may lead to further confusion, though.
  2. The Address Book prompts users with a Message Box that the new address will overwrite the old address in the Address Book.
  3. The label of the old address gets unset or set to "Unlabeled#X".

I suggest option 3, personally, but it's not my decision to make.

@leto
Copy link

leto commented Jul 11, 2019

I agree that current behavior can potentially lose data if done accidentally, and changing it to one of the 3 options would be better.

I vote for 2 since that seems most user-friendly to me

adityapk00 added a commit that referenced this issue Jul 11, 2019
@adityapk00
Copy link
Collaborator

I decided to prevent duplicate labels and let the user decide what to do.

@adityapk00
Copy link
Collaborator

Fixed in 0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants