Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate badges #423

Closed
michaelblyons opened this issue Jun 15, 2022 · 7 comments
Closed

Duplicate badges #423

michaelblyons opened this issue Jun 15, 2022 · 7 comments
Labels
bug Something isn't working planetiler Pending next planetiler release shields

Comments

@michaelblyons
Copy link
Contributor

I do not know whether this is your job to fix or not, but the US-15 in Virginia has north and southbound routes mapped separately. They're both part of a super-route. Anyway, the badge shows up twice.

Screen Shot 2022-06-15 at 6 51 59 PM

@1ec5
Copy link
Collaborator

1ec5 commented Jun 15, 2022

For reference, this way is a member of the northbound and southbound U.S. 15 route relations.

I can also reproduce this issue along this way that’s a member of the eastbound and westbound SR 32 route relations in Ohio:

SR 32

The problem lies in the vector tiles:

inspect

This would be fixed in openmaptiles/openmaptiles#1361.

@claysmalley claysmalley added bug Something isn't working shields blocked openmaptiles A change is needed in OpenMapTiles to support this labels Jun 15, 2022
@michaelblyons
Copy link
Contributor Author

openmaptiles/openmaptiles#1361 is merged now, but I don't know when the tiles become available.

@ZeLonewolf
Copy link
Owner

I'll build a full-zoom Ohio so we can test the behavior.

@ZeLonewolf
Copy link
Owner

We should probably decide how we want to administratively mark issues which are not resolved in the public demo but are fixed in the underlying software. It'll probably be awhile before a new release of OMT and a subsequent update of planetiler.

@ZeLonewolf
Copy link
Owner

From omt-tools render of Ohio:

(localhost link)
image

(localhost link)
image

@ZeLonewolf ZeLonewolf added planetiler Pending next planetiler release and removed openmaptiles A change is needed in OpenMapTiles to support this labels Jan 28, 2023
@michaelblyons
Copy link
Contributor Author

Maybe fixed? Can anyone confirm?

@1ec5
Copy link
Collaborator

1ec5 commented Feb 10, 2024

Yes, the same spot in #423 (comment) now shows only a single state route shield:

SR 32

@1ec5 1ec5 closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planetiler Pending next planetiler release shields
Projects
None yet
Development

No branches or pull requests

4 participants