Add shields for Great Lakes Circle Tour routes #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not US routes
1ec5
reviewed
Feb 1, 2023
|
Looking good at 100% zoom:
|
|
I added the Loop route for Lake Michigan. I can add more variants once when further mapping of these is done.
I also removed the light beams from the Lake Erie shield since I found them distracting. If people liked the other one better I can revert this.
|
ZeLonewolf
reviewed
Feb 1, 2023
The light beams are kind of cute; they probably make the lighthouse more recognizable. Does shortening the light beams help? |
|
Okay, I can live with this.
|
|
Looks good to me overall! Don't forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #569. The Lake Erie one is kinda busy but then again, so is the road sign. The other three I'm pretty happy with but I welcome feedback on all of this.