add commit callback #1
Conversation
|
WOW, even though the test files and source files are in the same directory, they have a different package |
pv97
force-pushed
the
add-commit-callback
branch
from
40dd253
to
ddb3122
Compare
| @@ -1,2 +1,3 @@ | |||
| documents | |||
| _book | |||
| .wercker | |||
| if !scope.HasError() { | ||
| scope.CallMethod("AfterUpdateCommit") | ||
| } | ||
| if !scope.HasError() { |
There was a problem hiding this comment.
Why do two different checks for the same thing?
There was a problem hiding this comment.
i am just following convention :D but maybe scope.CallMethod could result in changing HasError
There was a problem hiding this comment.
oooooooooooooooo. good fucking point.
| // afterUpdateCommitCallback will invoke `AfterUpdateCommit`, `AfterSaveCommit` method after update commit | ||
| func afterUpdateCommitCallback(scope *Scope) { | ||
| if _, ok := scope.Get("gorm:update_column"); !ok { | ||
| if !scope.HasError() { |
There was a problem hiding this comment.
If it has an error, is this somehow logged/or thrown to the api user at any point?
There was a problem hiding this comment.
it should return error to where you called the DB transaction like Save or Update
| @@ -53,6 +61,11 @@ func (s *Product) AfterSave() (err error) { | |||
| return | |||
| } | |||
|
|
|||
| func (s *Product) AfterSaveCommit() { | |||
There was a problem hiding this comment.
Is the difference between update and save actually update and create? Basically does save only mean create?
There was a problem hiding this comment.
I'm not sure why they have it this way, but calling Create both creates and saves, and calling Update both updates and saves
| @@ -18,6 +18,7 @@ func init() { | |||
| DefaultCallback.Update().Register("gorm:save_after_associations", saveAfterAssociationsCallback) | |||
| DefaultCallback.Update().Register("gorm:after_update", afterUpdateCallback) | |||
| DefaultCallback.Update().Register("gorm:commit_or_rollback_transaction", commitOrRollbackTransactionCallback) | |||
| DefaultCallback.Update().Register("gorm:after_update_commit", afterUpdateCommitCallback) | |||
There was a problem hiding this comment.
Interesting. So this is already an event?
There was a problem hiding this comment.
They will call whatever event you add in order.
There was a problem hiding this comment.
So just by registering you're creating an event as well?
There was a problem hiding this comment.
but then how is it to know that this should be triggered AFTER commit? And shouldn't there be a gorm:after_create_commit?
There was a problem hiding this comment.
they are called in the order they are defined here
Tests were not running locally, so updated
wercker.yamlAdd
After<Create/Update/Save/Delete>Commitcallbacks and updated tests for callbacks.Right now tests are failing because running tests doesn't build the latest changes for some reason. If I comment out all the old callbacks, they are still being called.
Dont merge yet btw.