Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Django 3.2 #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jramnai
Copy link

@jramnai jramnai commented Aug 30, 2021

This PR tests against Django 3.2 and updates the Django master branch with main.

@jramnai
Copy link
Author

jramnai commented Aug 31, 2021

@tonybajan, @stuartleigh any chance to review and merge this?

Copy link

@tonybajan tonybajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running tox locally is failing for me as main-branch Django now requires Python >=3.8 - we should avoid testing on previous versions.

@jramnai
Copy link
Author

jramnai commented Sep 9, 2021

@tonybajan, you were right. Django main-branch tests were failing while running tox locally.

Added a new commit which fixes the issue.

It is ready for your review now.

@jayvdb
Copy link

jayvdb commented Sep 17, 2021

Looks like this was done in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants