fix: go back while adding a book #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
abhishek-bodapati
approved these changes
May 18, 2021
Zelig880
requested changes
May 18, 2021
resources/js/pages/bookshelf/add.vue
Outdated
| resetSelection(){ | ||
| this.currentStep = 1 | ||
| this.selectedBook = null | ||
| this.$refs.bookSelection.$data.searchText = "" |
There was a problem hiding this comment.
Instead than set the SearchText, I would invoke the Method "resetSearch" available withint he BookshelfAddStep1. Also add some validation, just in case.
- Add JS validation to make sure that we just call the method if it is loaded (add an If(this.$refs.bookSelection && this.$refs.bookSelection.resetSearch)
- Change this line to call the "resetSearch" instead than reset just the string.
There was a problem hiding this comment.
I should have thought this earlier because just clearing the searchText will not toggle the disabled prop. Made these changes and amended them.
resources/js/pages/bookshelf/add.vue
Outdated
| <BookshelfAddStep2 v-if="currentStep >= 2" :disabled="currentStep !== 2" @select="selectCondition" /> | ||
| <Button v-if="currentStep === 3" class="float-right mt-6" @click="addToBookshelf">Add to your Bookshelf</Button> | ||
| <Button v-if="selectedBook" theme="secondary" color="secondary" class="float-right mt-6" :class="currentStep == 2 ? 'mr-0' : 'mr-6'" @click="resetSelection">Start again</Button> |
There was a problem hiding this comment.
Instead than add the logic of current step to define the margin right. You could just ALWAYS set Margin left on the Add to your Bookshelf Button!
- Remove the logic in the Reset button for MR
- Add the Margin Left on the Add to your Bookshelf button
There was a problem hiding this comment.
I can't really guess what I was thinking when I coded this. My bad. Made these changes and amended them.
Zelig880
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #54