Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce git-flow, PR and squash commit #66

Closed
gbenattar opened this issue Sep 9, 2019 · 3 comments
Closed

Enforce git-flow, PR and squash commit #66

gbenattar opened this issue Sep 9, 2019 · 3 comments
Assignees
@gbenattar

Comments

@gbenattar
Copy link
Contributor

gbenattar commented Sep 9, 2019 •
edited
Loading

Enforce git-flow, PR and squash commit
@gbenattar gbenattar self-assigned this Sep 9, 2019
@gbenattar gbenattar changed the title Enforce git-flow and commit message with Travis Enforce git-flow, PR and squash commit Sep 9, 2019
@gbenattar
Copy link
Contributor Author

Merging to master is possible only if

  • A PR received approval
  • Status check with Travis passed
  • Performed by an administrator

In addition, only squash commit from PR is enabled.

@gbenattar
Copy link
Contributor Author

When working on a change:

  • A github issue must be created
  • The name of the branch must be feature/[issue number], E.g. feature/66
  • The description of the PR has to be explicit. E.g.
Title: Introducing new curve ABCD

Motivation: ABCD is used in blockchain Z
Test: Unit test added and integration test against Z done etc...
Related Issue: 66

@gbenattar
Copy link
Contributor Author

I am closing this task.
Feel free to re-open if you have any questions.

@gbenattar gbenattar mentioned this issue Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbenattar gbenattar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbenattar