Feature/share popover #586
Conversation
dontry
force-pushed
the
feature/share-popover
branch
from
72991ca
to
b518368
Compare
src/components/SharePanel.jsx
Outdated
| return ( | ||
| <div className="share-panel"> | ||
| <h3 style={{ marginTop: '4px' }}>Share the Diagram on Confluence<sup>*</sup></h3> | ||
| {isLoading ? |
There was a problem hiding this comment.
Loading 状态可不可以只影响Copy Link那个Button。现在这样影响整个Panel，给用户的感觉响应太慢。用户看到静态内容，然后Copy Link稍微等一下是可以的，因为用户的注意力还没有立刻转移到那里。
src/components/SharePanel.jsx
Outdated
| <br /> | ||
| <div> | ||
| <p>Preview</p> | ||
| <div className="preview" > |
There was a problem hiding this comment.
Preview的设计请参考这个页面上的那个Card： https://zenuml-demo.atlassian.net/wiki/spaces/DEMO/pages/511049729/Embed+ZenUML.cn
|
@dontry Please resolve the conflict and update preview card according to https://github.com/ZenUml/web-app-laravel/pull/151 |
|
Once it is ready, please remove the "Draft" status. |
@MrCoder Can I remove all unecessary asyn/await from |
|
|
Visit the preview URL for this PR (updated for commit 934de2b): https://staging-zenuml-27954--pr586-feature-share-popove-h70n1rof.web.app (expires Sat, 11 Nov 2023 04:36:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6b46293b8a64352bd380930ba2a9594929b524e6 |
No description provided.