Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 add some tooling #5

Merged
merged 4 commits into from
Dec 10, 2019
Merged

🔧 add some tooling #5

merged 4 commits into from
Dec 10, 2019

Conversation

pyaillet
Copy link
Collaborator

@pyaillet pyaillet commented Dec 6, 2019

No description provided.

@pyaillet pyaillet added the WIP label Dec 6, 2019
Copy link
Member

@bgauduch bgauduch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Just one "echo" to correct 😉

--project=${GOOGLE_PROJECT_ID} \
firewall-rules delete default-allow-ssh

echo "Removing ssh registry rule..."
Copy link
Member

@bgauduch bgauduch Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Removing ssh registry rule" => "Removing registry firewall rule"

@pyaillet pyaillet merged commit b5e08fe into master Dec 10, 2019
@pyaillet pyaillet deleted the feat/tooling branch December 10, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants