New API for employees #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgwood
force-pushed
the
support-for-multiple-keys
branch
from
aef90eb
to
bc5916b
Compare
|
@Bugsyaya @yodur2potassium I will merge this because we need it for December 25 to make the Humeur du mois work with other countries but please review. :) |
hgwood
commented
Dec 23, 2018
| log.error("You have misconfigured your application! It should not" + | ||
| "run with both the 'dev' and 'cloud' profiles at the same time."); | ||
| } | ||
| } |
There was a problem hiding this comment.
There is no change in this method, it was simply moved by automated formatting.
| base-url: https://zenika.my.alibeez.com/api/query | ||
| key: | ||
| # newer Alibeez connector config for API v2 | ||
| instances: |
There was a problem hiding this comment.
This will not scale to multiple endpoints but for now it's good enough.
This was referenced Dec 23, 2018
hgwood
added a commit
to Zenika/humeur-du-mois
that referenced
this pull request
Dec 23, 2018
This makes Humeur pull employees of all countries. See Zenika/proxybeez#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API has better names for fields and pulls employees for all countries instead of just France.
The old API is still there and will keep working.