Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Use of postcss instead of glamor #115

Open
bpetetot opened this issue Aug 2, 2017 · 3 comments
Open

Use of postcss instead of glamor #115

bpetetot opened this issue Aug 2, 2017 · 3 comments

Comments

@bpetetot
Copy link
Contributor

bpetetot commented Aug 2, 2017

postcss can inject css into <style> (if you put the extract: false) like glamor
postcss could also bring css-modules, autoprefixer, nano, variables, imports, if we want...

Moreover with postcss we could add sass as preprocessor and consequently we could use (and improve) Kriya as main UI library.

@fabienjuif what do you think about that ?

@fabienjuif
Copy link
Contributor

why we didn't use CSS at first ?

  • we wanted a prepbuilt version, with a single JS file to inject into the target webpack
  • we didn't want that CSS override the tested component

with css-in-js we could avoid both concerns.
with postcss, I have the feeling that only the first one is resolved.

@bpetetot
Copy link
Contributor Author

bpetetot commented Aug 2, 2017

with css-modules, the second one is also resolve. no ?

@fabienjuif
Copy link
Contributor

we still could use :global or use a lib that use :global

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants