Some UI fixes to search autocomplete modal #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmayank
force-pushed
the
more-small-fixes
branch
from
cc5278f
to
c6985a5
Compare
Nnanyielugo
reviewed
May 18, 2022
| @@ -59,40 +58,30 @@ const AutocompleteModal: FunctionComponent<ModalWFinalFormProps> = ({ | |||
| const response = await handleTypeAhead(queryString); | |||
| if (response.data) { | |||
| setSuggestions(response.data); | |||
| setLoading(false); | |||
There was a problem hiding this comment.
The loading indicator is. meant to depict network activity because the locations are fetched over a network, and can be delayed sometimes.
There was a problem hiding this comment.
yeah, i think i prefer it without the indicator though. i checked some other apps and they don't have it either, they just update the results
mjmayank
force-pushed
the
more-small-fixes
branch
from
5d65c9b
to
6eea9e0
Compare
mjmayank
force-pushed
the
more-small-fixes
branch
from
6eea9e0
to
f3f0b3a
Compare
mjmayank
commented
May 18, 2022
| @@ -60,7 +60,6 @@ const AutocompleteModal: FunctionComponent<ModalWFinalFormProps> = ({ | |||
| if (response.data) { | |||
| setSuggestions(response.data); | |||
| setLoading(false); | |||
| Keyboard.dismiss(); | |||
There was a problem hiding this comment.
this was causing the keyboard to be dismissed as the user is typing
mjmayank
commented
May 18, 2022
| renderItem={_renderItem} | ||
| data={suggestions} | ||
| keyboardShouldPersistTaps="always" | ||
| showsVerticalScrollIndicator={false} |
There was a problem hiding this comment.
this works, but i prefer the CSS fix below of adjusting the padding and margin onto the correct elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.