Fix up amplitude events #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmayank
commented
Aug 1, 2022
| @@ -71,7 +71,7 @@ const ActivityType: FunctionComponent<ActivityTypeProps> = ({ navigation }) => { | |||
|
|
|||
| React.useEffect(() => { | |||
| sendEvent('page_view', { | |||
| screen: 'onboarding__activity', | |||
| type: 'onboarding__activity', | |||
There was a problem hiding this comment.
named this field wrong and want it to be consistent with what i did on web
mjmayank
commented
Aug 1, 2022
| @@ -101,7 +101,7 @@ export const registerUser = createAsyncThunk( | |||
| } | |||
|
|
|||
| await setStorage( | |||
| null, | |||
| response.user, | |||
There was a problem hiding this comment.
any idea why this was null before?
There was a problem hiding this comment.
At the time, the register endpoint did not return a user object.
mjmayank
commented
Aug 1, 2022
| @@ -418,6 +417,9 @@ const setStorage = async ( | |||
| refresh_token?: string, | |||
| ) => { | |||
| if (user) { | |||
| if (user.id) { | |||
There was a problem hiding this comment.
moved this here so that it's in a more central place
Nnanyielugo
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some small errors with one field name, and also wanted to optimize where the setID function goes