New BattlePoll message to inform Chobby about poll status

[DeinFreund]

    [Message(Origin.Server)]
    public class BattlePoll
    {
        public class PollOption
        {
            public string Name { get; set; }
            public int Id { get; set; }
            public int Votes { get; set; }
        }

        public string Topic { get; set; }
        public List<PollOption> Options { get; set; } //Empty if there is no poll
        public int VotesToWin { get; set; } //If any single option receives this many votes, it will win instantly
    }

https://github.com/ZeroK-RTS/Zero-K-Infrastructure/blob/ed017f8181f5d7a9105db04b2fa22834f6c6a541/Shared/LobbyClient/Protocol/Messages.cs#L830

[DeinFreund]

If there is no poll, VotesToWin is -1 and the other options are null

[GoogleFrog]

How does chobby send vote responses?

[DeinFreund]

!vote [Id]
It is also backwards compatible with !y and !n for polls with only two options.

[Licho1]

Imo if we make a message it should be done all at once. Ingame, chobby (preferably using common code)

Problem is, old system relies on chat for communication and not chobby protocol.

[GoogleFrog]

How often and under which circumstances is this command sent? I dislike the unbounded number of poll options.

[GoogleFrog]

How can this be tested?

[DeinFreund]

Merge ZeroK-RTS/Zero-K-Infrastructure#2431 to try it on the test server. Right now it will be four options for the automatic map vote and two options for all the old votes.

[GoogleFrog]

I want to use the current vote UI for yes/no votes, yet I see no hax-free way to detect these cases.

[DeinFreund]

Added a bool DefaultPoll to the message, this signifies that there are only two options and !y and !n will select them appropriately.

ZeroK-RTS/Zero-K-Infrastructure@07b53d8