Option polls #2431
Merged
Option polls #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d BattlePoll server message that is sent to inform users on poll updates.
|
Note that this requires changes ingame/chobby |
|
Yes, I'm waiting with this merge until @GoogleFrog is ready to use it in Chobby. |
sprunk
reviewed
Oct 23, 2018
| for (int i = 0; i < NumberOfMapChoices; i++) | ||
| { | ||
| Resource map; | ||
| if (i < NumberOfMapChoices / 2 && MinimalMapSupportLevel < MapSupportLevel.Featured) |
There was a problem hiding this comment.
could be simpler
Suggested change
| if (i < NumberOfMapChoices / 2 && MinimalMapSupportLevel < MapSupportLevel.Featured) | |
| if (i < NumberOfMapChoices / 2) |
There was a problem hiding this comment.
A server could be set to only allow Matchmaker maps. Imagine a 1v1 training server for example. In this case he should not show any featured maps.
DeinFreund
commented
Nov 26, 2018
| { | ||
| Ended = true; | ||
| await battle.SayBattle($"Poll: {question} [END:FAILED]"); | ||
| Outcome = new PollOutcome() { Success = false }; | ||
| await battle.SayBattle($"Poll Ended: {Topic} [No option achieved absolute majority]"); |
There was a problem hiding this comment.
These messages have to be backwards compatible for in-game.
| if (winCount <= 0) winCount = 1; | ||
|
|
||
| if (!await Vote(e, true)) | ||
| { | ||
| if (e == null) await battle.SayBattle($"Poll: {question} [!y=0/{winCount}, !n=0/{winCount}]"); |
There was a problem hiding this comment.
Same here, this can't be removed because in-game needs it.
DeinFreund
force-pushed
the
master
branch
2 times, most recently
from
d9749c6
to
38abd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polls now have multiple options instead of just Yes and No.