Anti-bait gadget for things like Artemis #3886

danfireman · 2020-04-18T23:21:19Z

Redone, tis the anti-chaff gadget is now ready for review.

sprunk · 2020-04-19T01:45:41Z

LuaRules/Gadgets/unit_overkill_prevention.lua

@@ -416,7 +488,10 @@ end

 function gadget:AllowCommand(unitID, unitDefID, teamID, cmdID, cmdParams, cmdOptions)
 	if (cmdID ~= CMD_PREVENT_OVERKILL) then
-		return true  -- command was not used


weird nesting, how about

if cmdID == CMD_PREVENT_OVERKILL then return PreventOverkillToggleCommand(unitID, cmdParams, cmdOptions) elseif cmdID == CMD_METAL_DESIRED_TO_PREVENT_OVERKILL then return PreventMetalOverkillToggleCommand(unitID, unitDefID, cmdParams, cmdOptions) else return true end

Sure, though pretty much everything I've written is horrible for this...

GoogleFrog · 2020-04-22T13:49:26Z

If it barely interacts with OKP then it does not need to be in the OKP gadget. I just thought you might need to use BlockShot and all the relevant units (should) already call an OKP function in BlockShot.

When making the new gadget make sure to look at other gadgets with gadget:AllowWeaponTarget and set the layer in a way that makes sense.

GoogleFrog · 2020-04-24T01:38:43Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+	params 	= {0, 0, 100, 300, 1000}
+}
+
+function GG.ChaffShootingPrevention_CheckMinMetal(unitID, targetID, damage)


Why is this GG?

Perhaps because you want to call GG.ChaffShootingPrevention_CheckMinMetal in Unit Priority to make such targets lower priority? Is that required with this interaction?

I don't think it's needed. Removed.

GoogleFrog · 2020-04-24T01:40:04Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+	end
+	return true, defPriority
+end
+


Should AllowWeaponTargetCheck or AllowUnitTargetRange also be used here?

I'm unclear on what the former does and can't find the latter in https://springrts.com/wiki/Lua:Callins

Experiment with both. See the gadget handler for AllowUnitTargetRange.

AllowUnitTargetRange is not a Spring callin. Spring overloads gadget:AllowWeaponTarget to do (at least) two distinct things by setting magic numbers in its parameters. I split one of the other uses off into AllowUnitTargetRange in the gadget handler.

LuaRules/Gadgets/unit_targetting_metal_limit.lua

GoogleFrog · 2020-04-24T01:43:40Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+
+	if spValidUnitID(unitID) and spValidUnitID(targetID) then
+		local gameFrame = spGetGameFrame()
+		local unitDefIDAsKnown = CallAsTeam(Spring.GetUnitTeam(unitID), spGetUnitDefID, targetID)


I prefer
local states = spGetUnitLosState(unitID, allyTeamID, true)
nowdays.

GoogleFrog · 2020-04-24T01:45:09Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+			preventChaffShootingCmdDesc.params = newParams
+			spEditUnitCmdDesc(unitID, cmdDescID, {params = preventChaffShootingCmdDesc.params})
+		end
+		Spring.SendLuaRulesMsg(minMetalMsg .. " ".. tostring(unitID) .. " " .. tostring(MetalHandledUnitDefIDs[unitDefID][state + 2]))


Why is a gadget sending a LuaRulesMsg?

So that people can write their own widgets that call in to the gadget and change a unit's minimum metal targetting threshhold.

I haven't split this into the UI widget and the underlying gadget yet.

danfireman · 2021-02-14T15:32:15Z

Ready for review @GoogleFrog

sprunk · 2021-02-14T16:09:35Z

LuaRules/Configs/unit_targetting_metal_limit_defs.lua

+-- Value is the default state of the command
+local metalThreshholdsByUnitDefIDs = {
+	[UnitDefNames["hoverarty"].id] = {0, 0, 100, 300, 1000},
+	[UnitDefNames["cloaksnipe"].id] = {0, 0, 100, 300, 1000},


Is this supposed to be the same table for every unit? In that case could do

Suggested change

-- Value is the default state of the command

local metalThreshholdsByUnitDefIDs = {

[UnitDefNames["hoverarty"].id] = {0, 0, 100, 300, 1000},

[UnitDefNames["cloaksnipe"].id] = {0, 0, 100, 300, 1000},

local STATES = {0, 0, 100, 300, 1000} -- first value is the default state of the command

local metalThreshholdsByUnitDefIDs = {

[UnitDefNames["hoverarty"].id] = STATES,

[UnitDefNames["cloaksnipe"].id] = STATES,

etc

That's due to me waffling back and forth over whether or not this should vary between units.

Eventually decided on simplicity.

Fixed now

sprunk · 2021-02-14T16:12:46Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+			preventChaffShootingCmdDesc.params = newParams
+			spEditUnitCmdDesc(unitID, cmdDescID, {params = preventChaffShootingCmdDesc.params})
+		end
+		Spring.SendLuaRulesMsg(minMetalMsg .. " ".. tostring(unitID) .. " " .. tostring(metalThreshholdsByUnitDefIDs[unitDefID][state + 2]))


Looks suspicious, why not just call the relevant thing directly?

Suggested change

Spring.SendLuaRulesMsg(minMetalMsg .. " ".. tostring(unitID) .. " " .. tostring(metalThreshholdsByUnitDefIDs[unitDefID][state + 2]))

unitMetalMin[unitID] = metalThreshholdsByUnitDefIDs[unitDefID][state + 2]

Can't remember what this was about...

Changed to your suggestion

sprunk · 2021-02-14T16:13:39Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+end
+
+function gadget:RecvLuaMsg (msg, playerID)
+	if msg:sub(1, #minMetalMsg) ~= minMetalMsg then


I'm unsure if the # operator works on string length reliably. But this whole func may not be needed, see above.

Removed function.

sprunk · 2021-02-14T16:15:17Z

LuaRules/Gadgets/unit_targetting_metal_limit.lua

+	if canHandleUnit[unitID] then
+		if unitMetalMin[unitID] then
+			unitMetalMin[unitID] = nil
+		end
+		canHandleUnit[unitID] = nil
+	end


Looking the value up takes just as much time as setting it

Suggested change

if canHandleUnit[unitID] then

if unitMetalMin[unitID] then

unitMetalMin[unitID] = nil

end

canHandleUnit[unitID] = nil

end

unitMetalMin[unitID] = nil

canHandleUnit[unitID] = nil

Doesn't that bloat canHandleUnit unnecessarily though? Taking up a (small) amount of extra memory on units that don't use metal threshhold targetting?

As far as I know nil takes up no space.

…t.lua

GoogleFrog · 2021-02-16T06:47:42Z

Whatever came of the idea of also adding a set of bad targets? Felon wants to shoot Ronin but not Razor. AA wants to shoot Raven but not Raptor, and both units cost the same. This gadget doesn't seem able to do either of these things.

I'm also wondering how to integrate it with the default UI. Maybe it should distinguish between manual commands and automatic target acquisition (don't fire at radar could have a mode where it does the same)? I'm not all that keen on adding a state toggle to the default UI, and it would be a shame for people to have to be told this exists to use it.

I will most likely look closer on the weekend.

GoogleFrog · 2021-02-21T01:21:10Z

Just updated the name for searchability.

GoogleFrog · 2021-02-21T02:47:13Z

A Phantom with Fight shoots Glaives.

GoogleFrog · 2021-02-21T02:47:57Z

Which is a bad thing.

GoogleFrog · 2021-02-21T02:55:37Z

Maybe it's not bad, but it is certainly an oversight. Solving this was the big task in Don't Fire At Radar, and I dislike my solution there. It messes with command queues a lot and possibly isn't even scalable. I was hoping for a solution here, but I guess this at least works perfectly for turrets (as far as I can tell) and units without Fight. I'll pull it on that basis, although I am going to have to rename everything so I can search it years later. I consider this type of thing 'bait', and don't think it should be tied exactly to metal.

sprunk reviewed Apr 19, 2020

View reviewed changes

danfireman marked this pull request as draft April 21, 2020 08:33

GoogleFrog reviewed Apr 24, 2020

View reviewed changes

LuaRules/Gadgets/unit_targetting_metal_limit.lua Outdated Show resolved Hide resolved

GoogleFrog reviewed Apr 24, 2020

View reviewed changes

Implementing means of getting units to avoid targetting chaff

ce24b2c

danfireman force-pushed the feature/targetBasedOnCost branch from e09f416 to ce24b2c Compare February 14, 2021 15:29

danfireman changed the title ~~WIP: Initial PoC of smart targetting based on cost~~ Initial PoC of smart targetting based on cost Feb 14, 2021

danfireman marked this pull request as ready for review February 14, 2021 15:30

danfireman changed the title ~~Initial PoC of smart targetting based on cost~~ New smart targetting gadget allowing units to avoid targetting low-cost units Feb 14, 2021

sprunk reviewed Feb 14, 2021

View reviewed changes

danfireman added 2 commits February 14, 2021 18:21

Tidying up unit_targetting_metal_limit_defs.lua

1dcfc54

Tidying: Getting rid of LuaRulesMsg use in unit_targetting_metal_limi…

45572ff

…t.lua

sprunk added 2 commits February 20, 2021 00:03

🎨 Keep customcmds.lua sorted by ID

8059fd5

📝 Document smart targetting gadget layer

7f1c52f

GoogleFrog changed the title ~~New smart targetting gadget allowing units to avoid targetting low-cost units~~ Anti-bait gadget for things like Artemis Feb 21, 2021

GoogleFrog merged commit b4bcfbc into ZeroK-RTS:master Feb 21, 2021

sprunk mentioned this pull request Apr 20, 2021

Implement some form of anti-bait #2789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anti-bait gadget for things like Artemis #3886

Anti-bait gadget for things like Artemis #3886

danfireman commented Apr 18, 2020 •

edited

sprunk Apr 19, 2020 •

edited

danfireman Apr 19, 2020

GoogleFrog commented Apr 22, 2020

GoogleFrog Apr 24, 2020

GoogleFrog Apr 24, 2020

danfireman May 9, 2020

GoogleFrog Apr 24, 2020

danfireman May 9, 2020

GoogleFrog May 10, 2020

GoogleFrog Feb 16, 2021

GoogleFrog Apr 24, 2020 •

edited

danfireman May 9, 2020

GoogleFrog Apr 24, 2020

danfireman May 9, 2020

danfireman commented Feb 14, 2021

sprunk Feb 14, 2021

danfireman Feb 14, 2021

sprunk Feb 14, 2021

danfireman Feb 14, 2021

sprunk Feb 14, 2021

danfireman Feb 14, 2021

sprunk Feb 14, 2021

danfireman Feb 14, 2021

GoogleFrog Feb 16, 2021

GoogleFrog commented Feb 16, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

	Spring.SendLuaRulesMsg(minMetalMsg .. " ".. tostring(unitID) .. " " .. tostring(metalThreshholdsByUnitDefIDs[unitDefID][state + 2]))
	unitMetalMin[unitID] = metalThreshholdsByUnitDefIDs[unitDefID][state + 2]

Anti-bait gadget for things like Artemis #3886

Anti-bait gadget for things like Artemis #3886

Conversation

danfireman commented Apr 18, 2020 • edited

sprunk Apr 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GoogleFrog commented Apr 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GoogleFrog Apr 24, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danfireman commented Feb 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GoogleFrog commented Feb 16, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

GoogleFrog commented Feb 21, 2021

danfireman commented Apr 18, 2020 •

edited

sprunk Apr 19, 2020 •

edited

GoogleFrog Apr 24, 2020 •

edited