Spread out units of same type in custom formation. #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not seen any issues with maxHngTime and maxNoXTime; however, they may need to be lowered as now these timeouts are now per unit type. I don't make large numbers of fleas, so I did not stress test it. |
|
I'm not sure how I feel about this situation: |
Cut down on tiny table creation. Remove pairs, ipairs. Remove unnecessary foreach. Reformulate priority into finding a maximum, as it doesn't require any properties of the underlying numbers (ie being at most 1). Replace empty declaration if-else chain with a function call. Removed explicit comparison with nil.
|
If the com has area cloak or shield, he needs to be centered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local function HasWaterWeapon(UnitDefID) is no longer used. and removed.