Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formation Ranks. #4644

Merged
merged 4 commits into from Mar 26, 2022
Merged

Add formation Ranks. #4644

merged 4 commits into from Mar 26, 2022

Conversation

amnykon
Copy link
Contributor

@amnykon amnykon commented Feb 24, 2022

Adds formation ranks to units other then planes, as it doesn't make much since for planes. Default formation rank is 2 for all units, which makes the default behavior the same as the current behavior.

Co-authored-by: sprunk <gnurps@o2.pl>
@GoogleFrog
Copy link
Contributor

I haven't had a chance to give this a review. But I like the idea. Here are some comments going into this which could speed things up.

  • I think this should have the same level of discoverability as selection rank. Ie, can be set in Unit Start State and the toggle can be enabled in Interface/Commands.
  • I think the defaults should be (almost?) all at some central value, such as formation rank 2. Perhaps AA and artillery could be 3. I would have to test to see how well it works, but I feel like the default should not do too much for the player.
  • The behaviour of the widget when everything has the same formation rank should be identical to the existing behaviour.

@amnykon
Copy link
Contributor Author

amnykon commented Feb 27, 2022

GoogleFrog, I agree and already accounted for. I think having aa and artillery default to 3 would look like a bug to a new player. It also makes a formation going to the left different than going to the right, which takes awhile to get used to. Dragging the wrong way puts artillery in front, which is usually bad. Adding dots on the formation line helps a lot and is basically needed for this. It was difficult to use this until I updated that piece.

@amnykon
Copy link
Contributor Author

amnykon commented Feb 27, 2022

If I was not clear, defaulting everything to the same value makes leftwards mouse drags identical to rightward drags, except for minor unit ordering from spacing out like units.

 * Reverse rank order so that clicking on the state toggle increases the value.
 * Added spacing option.
 * Normal players no longer execute redundant trig.
 * Removed assumption that the unitDefID of selected units is known.
@GoogleFrog GoogleFrog merged commit 03a9270 into ZeroK-RTS:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants