Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce typed defs, fix type hint #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

le91688
Copy link
Contributor

@le91688 le91688 commented Jul 28, 2023

No description provided.

@le91688 le91688 linked an issue Jul 28, 2023 that may be closed by this pull request
@chris-zetier
Copy link

Summary of changes

strict_optional -> deleted and thus the default value = true (already was)
check_untyped_defs -> deleted. (default value = false)
disallow_untyped_calls -> deleted. (default value = false) (already was)
warn_redundant_casts -> deleted. (default value = false)
disallow_untyped_defs -> Changed from False to True

And thus exposed a syntax error and later incompatible type::
src/lariat/lariat.py:184: error: Function is missing a type annotation for one or more arguments
Found 1 error in 1 file (checked 2 source files)
Fixing this we get type "Optional[Set[Any]]"; expected "Optional[List[str]]"

And you applied the fix which fixed this. Nice.

[mypy-bravado.client.]
[mypy-bravado.docstring_property.
]
[mypy-bravado.swagger_model.*]
sections deleted, probably because the imported bravado.client did not pass the mypy check. But looks like these were not necessary..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in get_devices type hint
2 participants