Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Refactor Popover provider #4663

Closed
3 tasks done
nathanlesage opened this issue Sep 16, 2023 · 0 comments
Closed
3 tasks done

[Develop] Refactor Popover provider #4663

nathanlesage opened this issue Sep 16, 2023 · 0 comments
Labels
enhancement This is an enhancement to a feature of Zettlr.

Comments

@nathanlesage
Copy link
Member

Description

Currently, the popovers across the app are managed by some very hacky logic implemented in less than ideally documented APIs in the Vue core. This was necessary when I did this because those have to be placed dynamically across the app outside the regular DOM flow. However, this is very brittle, as there is oftentimes something breaking due to the fragile logic. We now have the chance to improve this, since there is a new(ish) feature called teleport that potentially allows this.

Proposed Changes

Integrate Popovers more into the regular Vue workflow, e.g., via Teleports, to ensure that the regular data flow can be ensured.

Caveats

It might be that Teleport doesn't give us the fine-grained control over the positioning that we need; that would be something to check.

Do you Wish to Attempt Implementing this Yourself?

Yes

Zettlr Version

Right off the develop branch

Your Platform

  • Windows
  • macOS
  • Linux

Operating System Version

all

Additional Information

No response

@nathanlesage nathanlesage added the enhancement This is an enhancement to a feature of Zettlr. label Sep 16, 2023
nathanlesage added a commit that referenced this issue Feb 12, 2024
nathanlesage added a commit that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement to a feature of Zettlr.
Projects
Status: Done
Development

No branches or pull requests

1 participant