Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bielefeld theme sets font-family with !important #4719

Closed
2 of 5 tasks
josineto opened this issue Oct 5, 2023 · 0 comments
Closed
2 of 5 tasks

Bielefeld theme sets font-family with !important #4719

josineto opened this issue Oct 5, 2023 · 0 comments
Labels
bug A bug that affects the functionality of Zettlr.

Comments

@josineto
Copy link

josineto commented Oct 5, 2023

Description

The Bielefeld theme sets the font family using !important, which, according to own Zettlr documentation, "(...) is widely regarded as bad practice". Using debug mode > developer tools, I see the theme code snippet in question is as follows:

body .main-editor-wrapper .cm-scroller {
    font-family: 'Liberation Mono', Consolas, Menlo, monospace !important;
}

Due to this, I have to also use !important to change font family when using this theme.

Reproducing

  1. open Zettlr
  2. select Bielefeld theme in Preferences > Display
  3. activate debug mode
  4. open developer tools
  5. select the editor element, and find the CSS rule listed above

Zettlr Version

Stable (most recent version)

Specify version

3.0.0

Installation Method

Other (please specify below)

Your Platform

  • Windows
  • macOS
  • Linux

Architecture

  • Intel 64bit
  • ARM 64bit

Operating System Version

Linux Manjaro, Gnome 44

Additional Information

No response

@josineto josineto added the bug A bug that affects the functionality of Zettlr. label Oct 5, 2023
nathanlesage added a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug that affects the functionality of Zettlr.
Projects
None yet
Development

No branches or pull requests

1 participant