Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zkn autocomplete trigger #4653

Merged
merged 4 commits into from Sep 17, 2023
Merged

Conversation

kyaso
Copy link
Collaborator

@kyaso kyaso commented Sep 13, 2023

Description

This PR addresses the issue mentioned in #4616 (comment).

Tested on: Linux Manjaro

@nathanlesage
Copy link
Member

So this fixes the issue you were observing, right? To me, it looks functional and thus good to go. (There are a few conflicts, though, do you mind going over them?)

@kyaso
Copy link
Collaborator Author

kyaso commented Sep 16, 2023

So this fixes the issue you were observing, right?

Yes, this resolves the issue where the autocomplete pop-up would not show up when editing a Zkn link with another link preceding it.

@nathanlesage
Copy link
Member

Perfect, thank you! Merging now! I appreciate your help, it is really, really nice that you support me in fixing bugs as much as you do.

@nathanlesage nathanlesage merged commit 2b56553 into Zettlr:develop Sep 17, 2023
1 check failed
@kyaso kyaso deleted the fix/link-autocomplete branch September 17, 2023 21:12
@kyaso
Copy link
Collaborator Author

kyaso commented Sep 17, 2023

Perfect, thank you! Merging now! I appreciate your help, it is really, really nice that you support me in fixing bugs as much as you do.

Anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants