-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement novel Preferences UI #4805
Conversation
* This commit enables the usage of a single form field in the header
Hello! As discussed, here are the padding measurements in pixels: ![]() ![]() ![]() Please let me know if you need any other measurements. Alternatively, this page describes how to inspect the design files in detail using the Inspect tab in the web version of Sketch. (It didn't work during our call earlier because the layers were locked, but I unlocked them now.) |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Kirthihan Yasotharan <kirthihan.y@gmail.com> Co-authored-by: pseandersson <5318749+pseandersson@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: தமிழ்நேரம் <67970539+TamilNeram@users.noreply.github.com>
I will now merge this PR so that I can continue working on various other issues that riddle the app. We'll fix anything that comes up during the 3.1.0 beta cycle. |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: தமிழ்நேரம் <67970539+TamilNeram@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kirthihan Yasotharan <kirthihan.y@gmail.com> Co-authored-by: pseandersson <5318749+pseandersson@users.noreply.github.com> Co-authored-by: Joop Kiefte <ikojba@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: தமிழ்நேரம் <67970539+TamilNeram@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kirthihan Yasotharan <kirthihan.y@gmail.com> Co-authored-by: pseandersson <5318749+pseandersson@users.noreply.github.com> Co-authored-by: Joop Kiefte <ikojba@gmail.com>
Description
This PR implements a set of layout and design changes that @sensologica and me have been developing over the course of 2023. We have had many meetings, adjusting how the preferences look, and how users would interact with them.
At this point, I would already like to thank Artem for helping the project out with such indispensable resources in the Open Source space such as UI/UX design! 🎉
The main goal was to create a design that would tick a set of boxes:
The New Design
This is what the whole thing will look like when the PR is finished:
Thanks to Artem for all this work!
Changes
The set of changes are fairly quick to go over:
SelectableList
SelectableList
has been adapted (still some way to go)Additional information
In addition to these changes, I took the liberty to streamline how the form is being built, and tried to get rid of some technical debt. In addition, I found a few settings that have been added after the design has been finalized; we may need to move them around a bit.
To-Dos
There are a few things still todo:
Tested on: macOS Sonoma 14.1.1