Issue 4921 reopen : Show the Title instead of the file name in the popup file preview #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essed up the commit history
imalexhu
changed the title
nathanlesage
requested changes
May 22, 2024
source/app/service-providers/commands/file-find-and-return-meta-data.ts
Outdated
Show resolved
Hide resolved
|
@nathanlesage The changes that were requested have been resolved |
|
Wonderful, thank you! Merging now … |
|
There we go, your PR got merged! Welcome to the party! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is me reopening this pervious PR as I messed up the merge history. The code is still the same and follows the suggestions provided.
Previous PR can be visited here -> #5128
Changes
The file-find-and-return-meta data query now returns previewTitle depending on user filename display settings
Tested on: MacOs 14.3.1