Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search in folder autofocus #5182

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

viktomas
Copy link
Contributor

@viktomas viktomas commented May 24, 2024

Description

This MR fixes a bug when autofocus for the "search in folder" (aka. global search) panel stopped working

before after
zettlr-focus-before zettlr-focus-after

I tested it locally

Changes

The ref of the input component was incorrect.

Additional information

The issue was introduced in 3ecba46

yarn test fails for me locally (immediately without running any tests)

Exception during run: TypeError: Cannot set property navigator of #<Object> which has only a getter

Tested on: latest MacOS 14.5 (23F79)

Copy link

boring-cyborg bot commented May 24, 2024

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

  • Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
    way it was implemented is not immediately obvious?
  • Did you attempt to stick as much to current coding habits as possible?
    (Note that this does not apply to pieces of code where we ourselves
    obviously violated good coding practices, which unfortunately happens
    sometimes. But please indicate this in your PR so that we know what you
    rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

@viktomas viktomas force-pushed the tv/fix-global-search-focus branch from b9bfe5a to c853b05 Compare May 24, 2024 19:43
@nathanlesage
Copy link
Member

The error you get seem to be something borked in your setup, but no worries, the pipeline correctly reports that all is good with your PR! Thanks, merging in

@nathanlesage nathanlesage merged commit 8ab50e4 into Zettlr:develop Jun 8, 2024
1 check passed
Copy link

boring-cyborg bot commented Jun 8, 2024

There we go, your PR got merged! Welcome to the party! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants