Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: names of Czech and Slovak languages in Settings->Language #1248

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

iWarpBTC
Copy link
Contributor

@iWarpBTC iWarpBTC commented Jan 1, 2023

Description

This PR just tries to correct names for Czech and Slovak languages in Settings->Language. I cannot test so dunno if I'm not breaking anything.

Just for the record 'Češka' means a Czech female. 'Česky' would mean 'in Czech language' but more common is to state the name 'čeština'.

Pretty the same for the Slovak language: Slovák / slovenčina

See for example:
obrazek

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor

kaloudis commented Jan 1, 2023

This is my error. Thanks a bunch for the correction.

@kaloudis kaloudis merged commit c931245 into ZeusLN:master Jan 2, 2023
@iWarpBTC iWarpBTC deleted the cs_sk branch January 3, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants