Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Payments: allow the user to change their default fee limit #1256

Merged

Conversation

Ovifer13
Copy link
Contributor

@Ovifer13 Ovifer13 commented Jan 9, 2023

Description

Relates to issue: ZEUS-#1106

Creation of the payments tab where users will be able to change their default fee

image

Video example
https://www.loom.com/share/2b40ab71f4d4408b8f6382317f0f8350

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@Ovifer13 Ovifer13 marked this pull request as ready for review January 9, 2023 21:03
feeOption: 'sats',
feeOption: 'fixed',
Copy link
Contributor

@otech47 otech47 Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For improved type-safety, maybe we should use an enum for this and update the InvoiceState and PaymentSettings interfaces

Copy link
Contributor

@kaloudis kaloudis Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this. Spoke with Ovidio and agreed to tackle enums more broadly - throughout the app - in another issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking here: #1262

@kaloudis
Copy link
Contributor

tACK. Great job, Ovidio!!

@kaloudis
Copy link
Contributor

@Ovifer13 merging this in with squashed commits. When you have some time again I'd like to teach you how to restructure your commits. This will make review of code much easier and make for cleaner PRs.

Nonetheless, great work. Will get users testing this ASAP.

@kaloudis kaloudis changed the title Allow the user to change their default fee limit in settings Settings: Payments: allow the user to change their default fee limit Jan 18, 2023
@kaloudis kaloudis merged commit 5dafc4d into ZeusLN:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants