Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto-capitalization of hostname on iOS #1263

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Prevent auto-capitalization of hostname on iOS #1263

merged 1 commit into from
Jan 19, 2023

Conversation

joegesualdo
Copy link
Contributor

@joegesualdo joegesualdo commented Jan 19, 2023

Description

Relates to issue: ZEUS-0000

When entering the node hostname, iOS was automatically capitalizing the first letter. For example, it wasn't possible to type "hostname" because it was switching to "Hostname".

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS -- Simulator iPone 14+

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@joegesualdo joegesualdo changed the title Prevent auto capitalization of the first letter on iOS. Prevent auto-capitalization of hostname on iOS. Jan 19, 2023
@kaloudis
Copy link
Contributor

Nice first contribution

@kaloudis kaloudis changed the title Prevent auto-capitalization of hostname on iOS. Prevent auto-capitalization of hostname on iOS Jan 19, 2023
@kaloudis kaloudis merged commit 7bc253d into ZeusLN:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants