ZEUS-1419: LNURL-w fixed value patch

[kaloudis]

Description

Relates to issue: ZEUS-1419

Fixed value LNURL-w was not able to be claimed when invoice settings were not defined as it broke the UNSAFE_componentWillMount block in views/Receive.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• Core Lightning (Spark)
• Eclair
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[prusnak]

@kaloudis Is there a CI where can I download binaries for testing?

[kaloudis]

@prusnak not yet

[prusnak]

I tried to build via ./build.sh but my build always fails with the following error while fetching the docker layers:

docker: failed to register layer: Error processing tar file(exit status 1): write /opt/android/system-images/android-21/google_apis/armeabi-v7a/system.img: no space left on device.

Not sure what's going on - I have plenty of disk space available.

[kaloudis]

@prusnak very interesting. what OS are you running it on?

[prusnak]

very interesting. what OS are you running it on?

macOS 13.1

[prusnak]

Anyway, here's the QR code with LNURL-w for 10 satoshis to reproduce the issue (amount is set to 0 and editing is disabled):

---

This one contains LNURL-w with range 10-12 satoshis. Amount is still set to 0 by default, but I can edit it and thus withdraw:

---

Maybe the default amount shouldn't be set to zero but set to max? Or better is to set to min so we are not greedy?

[shubhamkmr04]

tACK