AddNotes: Add notes after payment #1447
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import * as React from 'react'; | ||
| import { View, TextInput } from 'react-native'; | ||
| import EncryptedStorage from 'react-native-encrypted-storage'; | ||
|
|
||
| import Header from '../components/Header'; | ||
| import Screen from '../components/Screen'; | ||
| import Button from '../components/Button'; | ||
|
|
||
| import { themeColor } from '../utils/ThemeUtils'; | ||
|
|
||
| interface AddNotesProps { | ||
| navigation: any; | ||
| } | ||
| interface AddNotesState { | ||
| notes?: string; | ||
| payment_hash?: string; | ||
| txid?: string; | ||
| } | ||
|
|
||
| export default class AddNotes extends React.Component< | ||
| AddNotesProps, | ||
| AddNotesState | ||
| > { | ||
| constructor(props: any) { | ||
| super(props); | ||
| const payment_hash: string = this.props.navigation.getParam( | ||
| 'payment_hash', | ||
| null | ||
| ); | ||
| const txid: string = this.props.navigation.getParam('txid', null); | ||
|
|
||
| this.state = { | ||
| notes: '', | ||
| payment_hash, | ||
| txid | ||
| }; | ||
| } | ||
| async componentDidMount() { | ||
| const key: any = this.state.txid || this.state.payment_hash; | ||
| const storedNotes = await EncryptedStorage.getItem(key); | ||
| if (storedNotes) { | ||
| this.setState({ notes: storedNotes }); | ||
| } | ||
| } | ||
|
|
||
| render() { | ||
| const { navigation } = this.props; | ||
| const { payment_hash, txid } = this.state; | ||
| const { notes } = this.state; | ||
| return ( | ||
| <Screen> | ||
| <Header | ||
| leftComponent="Back" | ||
| centerComponent={{ | ||
| text: 'Add a note', | ||
| style: { | ||
| color: themeColor('text'), | ||
| fontFamily: 'Lato-Regular', | ||
| fontSize: 20 | ||
| } | ||
| }} | ||
| navigation={navigation} | ||
| /> | ||
| <View style={{ padding: 20 }}> | ||
| <TextInput | ||
| onChangeText={(text: string) => { | ||
| this.setState({ notes: text }); | ||
| }} | ||
| multiline | ||
| numberOfLines={0} | ||
| style={{ fontSize: 20 }} | ||
|
There was a problem hiding this comment. should also have |
||
| value={notes} | ||
| /> | ||
| </View> | ||
| <Button | ||
| onPress={async () => { | ||
| navigation.navigate('Wallet'); | ||
|
There was a problem hiding this comment. instead of navigating back to the wallet it should navigate back to the previous screen There was a problem hiding this comment. Ohh I was also thinking to do it, will do it |
||
| const key: any = payment_hash || txid; | ||
|
There was a problem hiding this comment. let's make the key prefixed with |
||
| await EncryptedStorage.setItem(key, notes); | ||
| }} | ||
| containerStyle={{ position: 'absolute', bottom: 40 }} | ||
| buttonStyle={{ padding: 15 }} | ||
| title="add note" | ||
|
There was a problem hiding this comment. use a locale for this string too |
||
| /> | ||
| </Screen> | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wee just just use a singular definition here instead of requiring translators to translate it multiple times.
Also think it might be better as
NotesingularThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I thought there are different
viewsin which we are using them so I did that, like we would have to use{localeString('views.Payment.notes')}inTransactionviewThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its okay, I'll use only one definition