AddNotes: Add notes after payment #1447

shubhamkmr04 · 2023-04-25T12:36:41Z

This PR adds functionality to add notes with lightning payments, Onchain Transactions and Invoice, and later, users can see the notes inside the Activity view and edit them from there.

kaloudis · 2023-04-26T13:20:19Z

views/AddNotes.tsx

+                <Button
+                    onPress={async () => {
+                        navigation.navigate('Wallet');
+                        const key: any = payment_hash || txid;


let's make the key prefixed with note-

kaloudis · 2023-04-26T13:20:30Z

views/AddNotes.tsx

+                    }}
+                    containerStyle={{ position: 'absolute', bottom: 40 }}
+                    buttonStyle={{ padding: 15 }}
+                    title="add note"


use a locale for this string too

kaloudis · 2023-04-26T13:21:14Z

views/Payment.tsx

@@ -35,10 +39,18 @@ export default class PaymentView extends React.Component<PaymentProps> {
        if (lnurlpaytx) {
            this.setState({ lnurlpaytx });
        }
+        EncryptedStorage.getItem(payment.payment_hash)


make sure you update the key format here too

kaloudis · 2023-04-26T13:22:09Z

Looking solid overall. Please add some screenshots to the PR.

shubhamkmr04 · 2023-04-26T14:26:09Z

Looking solid overall. Please add some screenshots to the PR.

Thanks! Did the changes.

kaloudis · 2023-04-26T14:39:55Z

I think we should also add this functionality to Invoices (LN payments you've requested) as well. Yes you have some information from the memo but it would be nice to add notes you didn't expose to the payer.

kaloudis · 2023-04-26T14:40:34Z

Also, please add a screenshot of the Add Note view

shubhamkmr04 · 2023-04-26T14:47:33Z

I think we should also add this functionality to Invoices (LN payments you've requested) as well. Yes you have some information from the memo but it would be nice to add notes you didn't expose to the payer.

Okay. I'll do it

kaloudis · 2023-04-26T15:36:34Z

locales/en.json

@@ -556,6 +559,7 @@
    "views.Transaction.numConf": "Number of Confirmations",
    "views.Transaction.status": "Status",
    "views.Transaction.timestamp": "Timestamp",
+    "views.Transaction.notes": "Notes",


wee just just use a singular definition here instead of requiring translators to translate it multiple times.

Also think it might be better as Note singular

Okay, I thought there are different views in which we are using them so I did that, like we would have to use {localeString('views.Payment.notes')} in Transaction view

Its okay, I'll use only one definition

kaloudis · 2023-04-26T15:36:57Z

views/AddNotes.tsx

+                        }}
+                        multiline
+                        numberOfLines={0}
+                        style={{ fontSize: 20 }}


should also have color: themeColor('text')

kaloudis · 2023-04-26T15:37:34Z

views/AddNotes.tsx

+                <Button
+                    title={localeString('views.AddNotes.AddNote')}
+                    onPress={async () => {
+                        navigation.navigate('Wallet');


instead of navigating back to the wallet it should navigate back to the previous screen

Ohh I was also thinking to do it, will do it

kaloudis · 2023-04-26T15:40:05Z

views/AddNotes.tsx

+                <Header
+                    leftComponent="Back"
+                    centerComponent={{
+                        text: localeString('views.AddNotes.AddNote'),


maybe this says 'Update Note' if the note already exists

kaloudis · 2023-04-26T15:53:03Z

Lastly, I think you should also be able to go to a AddNote view if you click on the note in the Payment/Invoice/TX view

shubhamkmr04 · 2023-04-26T15:55:20Z

Lastly, I think you should also be able to go to a AddNote view if you click on the note in the Payment/Invoice/TX view

Like when I tap on the Note itself?

kaloudis · 2023-04-26T15:59:05Z

Lastly, I think you should also be able to go to a AddNote view if you click on the note in the Payment/Invoice/TX view

Like when I tap on the Note itself?

exactly

kaloudis · 2023-05-04T14:25:12Z

views/AddNotes.tsx

+                        const key: any =
+                            'note-' + (payment_hash || txid || RPreimage);
+                        await EncryptedStorage.setItem(key, notes);
+                        if (!noteKeys.includes(key)) {


This needs to be populated when you load the note, or perhaps in a a separate note store.

You also need to add logic to remove it from the index if the user deletes the note

I have added the logic to remove keys from noteKeys array, in onChangeText prop

kaloudis · 2023-05-15T18:38:44Z

stores/NotesStore.ts

+    @observable public noteKeys: string[] = [];
+
+    @action
+    public storingNoteKeys = async (key: string, notes: string) => {


let's call it storeNoteKeys or saveNoteKeys

kaloudis · 2023-05-15T18:39:14Z

views/AddNotes.tsx

+                        onChangeText={(text: string) => {
+                            this.setState({ notes: text });
+                            if (!text) {
+                                const key: any =


type is string here

kaloudis · 2023-05-22T16:54:11Z

Add a Note button should always be at the bottom:

kaloudis · 2023-05-22T16:54:58Z

views/AddNotes.tsx

+                <Header
+                    leftComponent="Back"
+                    centerComponent={{
+                        text: notes


this text shouldn't be dependent on whether the note in the state is set, rather if a previous note has been saved

same with the button at the bottom of this view

kaloudis · 2023-05-25T18:09:04Z

Note button styling is inconsistent on the Traction view

AndySchroder · 2024-03-07T19:27:11Z

Are these notes stored on LND or on the phone?

AddNotes: Add notes after payment

3cb9562

shubhamkmr04 force-pushed the shubham/Notes branch from b5c31c8 to 3cb9562 Compare April 25, 2023 12:40

shubhamkmr04 marked this pull request as draft April 25, 2023 12:40

Added notes for Onchain transaction, Payment view and Transaction view

93ff868

shubhamkmr04 marked this pull request as ready for review April 26, 2023 12:54

kaloudis reviewed Apr 26, 2023

View reviewed changes

Add prefix 'note-' in the key to fetch notes

1eae97c

shubhamkmr04 requested a review from kaloudis April 26, 2023 14:29

kaloudis added this to the v0.7.6 milestone Apr 26, 2023

kaloudis reviewed Apr 26, 2023

View reviewed changes

ZeusLN deleted a comment from shubhamkmr04 Apr 26, 2023

shubhamkmr04 added 4 commits April 27, 2023 22:41

Fixed all the issues raised in comments

65e89c1

Added notes on invoice

f9eb5a6

Added 'Add/Update note' button on Transaction and Payment view as well

6f87432

Storing keys separately that are used to fetch notes

45294d4

kaloudis reviewed May 4, 2023

View reviewed changes

shubhamkmr04 requested a review from kaloudis May 5, 2023 20:09

shubhamkmr04 force-pushed the shubham/Notes branch from 0d57306 to bfc9f10 Compare May 6, 2023 03:47

kaloudis reviewed May 15, 2023

View reviewed changes

NotesStore: Storing and removing keys

9f5c2f5

shubhamkmr04 force-pushed the shubham/Notes branch from bfc9f10 to 9f5c2f5 Compare May 16, 2023 02:12

shubhamkmr04 requested a review from kaloudis May 19, 2023 16:25

kaloudis reviewed May 22, 2023

View reviewed changes

Fixing Add notes btn position, Btn/header text depending on stored notes

c83530a

Fixed margin and button style

da0b5e3

shubhamkmr04 force-pushed the shubham/Notes branch from 043cb80 to da0b5e3 Compare May 26, 2023 16:56

NotesStore: removeNoteKeys: update local storage

bb18fbe

kaloudis force-pushed the shubham/Notes branch from 68523b7 to bb18fbe Compare May 30, 2023 03:09

kaloudis merged commit 3666e78 into ZeusLN:master May 30, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AddNotes: Add notes after payment #1447

AddNotes: Add notes after payment #1447

shubhamkmr04 commented Apr 25, 2023 •

edited

kaloudis Apr 26, 2023

kaloudis Apr 26, 2023

kaloudis Apr 26, 2023

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023

kaloudis commented Apr 26, 2023

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023

kaloudis Apr 26, 2023

shubhamkmr04 Apr 26, 2023

shubhamkmr04 Apr 26, 2023

kaloudis Apr 26, 2023

kaloudis Apr 26, 2023

shubhamkmr04 Apr 26, 2023

kaloudis Apr 26, 2023

shubhamkmr04 Apr 26, 2023

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023 •

edited

kaloudis commented Apr 26, 2023

kaloudis May 4, 2023

shubhamkmr04 May 4, 2023

kaloudis May 15, 2023

kaloudis May 15, 2023 •

edited

kaloudis commented May 22, 2023

kaloudis May 22, 2023

kaloudis May 22, 2023

kaloudis commented May 25, 2023

AndySchroder commented Mar 7, 2024

AddNotes: Add notes after payment #1447

AddNotes: Add notes after payment #1447

Conversation

shubhamkmr04 commented Apr 25, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023

kaloudis commented Apr 26, 2023

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis commented Apr 26, 2023

shubhamkmr04 commented Apr 26, 2023 • edited

kaloudis commented Apr 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis May 15, 2023 • edited

Choose a reason for hiding this comment

kaloudis commented May 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaloudis commented May 25, 2023

AndySchroder commented Mar 7, 2024

shubhamkmr04 commented Apr 25, 2023 •

edited

shubhamkmr04 commented Apr 26, 2023 •

edited

kaloudis May 15, 2023 •

edited