Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat currency conversion: Moscow time #1588

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Aug 5, 2023

Description

Fixed the display of the fiat conversion rates, when unit is set to sats

BEFORE
Simulator Screen Shot - iPhone 14 - 2023-08-05 at 18 49 57

AFTER
Simulator Screen Shot - iPhone 14 - 2023-08-09 at 13 58 47

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@myxmaster
Copy link
Contributor

Nice! Here are some more ideas how to format it:
a. $1.61 | 3,441 sats/1 USD
b. $1.61 | 3,441 sats/$1
c. $1.61 | 3,441 sats = 1 USD
d. $1.61 ($1 = 3,441 sats)

I like c and d best.

@kaloudis
Copy link
Contributor Author

kaloudis commented Aug 9, 2023

Updated the display:

Simulator Screen Shot - iPhone 14 - 2023-08-09 at 13 58 47

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1691654944
Screenshot_1691654914

The conversion here looks kiinda consfusing. Maybe it should be just $29,483.117 = 1 BTC or just $29,483.117/BTC

@kaloudis
Copy link
Contributor Author

@shubhamkmr04 let's revisit the other displays at a later time. For now I think this is an improvement over the sats rate we had

@kaloudis kaloudis merged commit 6cec08b into ZeusLN:master Aug 17, 2023
3 checks passed
@kaloudis kaloudis deleted the fiat-currency-moscow branch August 17, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants