Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info Modal and Text components #1621

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Info Modal and Text components #1621

merged 4 commits into from
Aug 25, 2023

Conversation

kaloudis
Copy link
Contributor

Description

Creates new InfoModal and Text components that can be used to give users more information about certain settings or values.

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-24.at.17.49.36.mp4

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@dipunm
Copy link

dipunm commented Aug 24, 2023

  1. Why does wrapping payments make payments easier?

I assume if Zeus is offline, then payment will fail unless it is wrapped?

  1. With routing hints, does it have any effect if all channels are announced? Maybe it can be removed if there are no unannounced channels to give routing hints for. Also does it have any effect if using wrapped payments?

@kaloudis
Copy link
Contributor Author

  1. Why does wrapping payments make payments easier?

I assume if Zeus is offline, then payment will fail unless it is wrapped?

2. With routing hints, does it have any effect if all channels are announced? Maybe it can be removed if there are no unannounced channels to give routing hints for. Also does it have any effect if using wrapped payments?
  1. Just created fleshed out LSP overview and wrapped invoice explanation pages

  2. Routing hints aren't necessary when using the LSP so they won't show up as an option when the LSP is enabled anymore. The LSP will continue to attempt to settle the payment with the end user if they are offline at the time of the original payment but the user has to have their Zeus online to settle the payment.

@kaloudis kaloudis merged commit cea0af7 into ZeusLN:master Aug 25, 2023
3 checks passed
@kaloudis kaloudis deleted the info-modal branch August 25, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants