Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Node settings: wait for graph sync #1643

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Sep 4, 2023

Description

This PR adds a setting for Embedded Nodes, waitForGraphSync that prevents users from attempting to pay lightning invoices before the node is synced up graph. It is on by default. Alpha testers have noted that sending before this sync often puts payments in flight without confirmation of settlement. Users might end up sending multiple payments or getting confused.

Users will also be prevented from attempting to pay lightning invoices before the node is synced to the graph and before they have at least one active channel. Users will not be able to opt out of this check.

Lastly, the PaymentRequest view now has an indicator showing that LND is getting ready to make payments. The pay button will be disabled until LND is synced.

Simulator Screen Shot - iPhone 14 - 2023-09-04 at 14 11 31

Simulator.Screen.Recording.-.iPhone.14.-.2023-09-04.at.14.13.05.mp4

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis merged commit 1a0a31e into ZeusLN:master Sep 4, 2023
3 checks passed
@kaloudis kaloudis deleted the wait-for-sync branch September 4, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant