Embedded Node settings: wait for graph sync #1643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a setting for Embedded Nodes,
waitForGraphSync
that prevents users from attempting to pay lightning invoices before the node is synced up graph. It is on by default. Alpha testers have noted that sending before this sync often puts payments in flight without confirmation of settlement. Users might end up sending multiple payments or getting confused.Users will also be prevented from attempting to pay lightning invoices before the node is synced to the graph and before they have at least one active channel. Users will not be able to opt out of this check.
Lastly, the
PaymentRequest
view now has an indicator showing that LND is getting ready to make payments. The pay button will be disabled until LND is synced.Simulator.Screen.Recording.-.iPhone.14.-.2023-09-04.at.14.13.05.mp4
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: