Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts: Fixes #1668

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Contacts: Fixes #1668

merged 4 commits into from
Sep 20, 2023

Conversation

shubhamkmr04
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 commented Sep 19, 2023

  • Fixing the size of Header icons, mainly the Back button on the AddContact, Contacts and ContactDetails view.
  • Disabling the SAVE CONTACT button if an extra field of pubkey is generated and not being filled correctly.
  • On AddContactPreviously we had to tap on the plus icon to open the gallery for adding photos, we changed that to make the whole background circle pressable.
  • If the contact has only one address available (either lnAddress, onchainAddress, or pubkey) , we get forwarded to the payments and skip going to ContactDetails view only if the user is coming from the Send view (we still will be forwarded to the ContactDetails view if we coming from Settings so the user can edit the contact).

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/Contact_Fixes branch 2 times, most recently from 601c7ab to c17fc2d Compare September 19, 2023 18:27
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 1f9dd1d into ZeusLN:master Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants