Remove scramble pin hint on confirmation screen

[myxmaster]

Description

Even when "Scramble PIN numbers" is disabled, the related hint was displayed on confirm PIN screen.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

What do you mean by the hint? Confused by the change here.

[myxmaster]

This one:

[kaloudis]

That's what I thought. I don't understand the incentive behind this change at all.

[myxmaster]

The hint should not be displayed when "Scramble PIN numbers" is disabled.

[kaloudis]

But why? This has nothing to do with the scrambling of the pin. The user has already just set their pin. The hint lets them verify the length of the pin they just entered.

[myxmaster]

I am referring to this hint:

The order of numbers on the PIN Pad is randomized to prevent against attacks

This has nothing to do with the length of the PIN but only with PIN numbers scrambling.

[kaloudis]

I understand now! The text hint.

[kaloudis]

tACK