Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked activity date filter #1685

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

myxmaster
Copy link
Contributor

Description

Reworked the activity date filter:

  • Start and end date are in separate rows now
  • The filter now is a real date filter, time is ignored (using 0-24h of local time zone)
  • Date picker is now modal and uses the configured language (not system language)
  • The date pickers now have minimum/maximum dates depending on the "opposite" date
  • The filter is now re-applied when it is cleared completely or a date filter is cleared

Before:

grafik

After:

grafik
grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1696064412
Getting some errors on tapping Start date/End date on 'Filter activity' view

@myxmaster
Copy link
Contributor Author

Do you mean tapping on the Set buttons? I just checked it again and don't get any errors. Have you run yarn?

@shubhamkmr04
Copy link
Contributor

Do you mean tapping on the Set buttons? I just checked it again and don't get any errors. Have you run yarn?

Yes, binary files must not be in place before; it works fine now. Thanks

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@kaloudis kaloudis merged commit c5b34fb into ZeusLN:master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants