Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send: Fix - Reset isValid state during input validation #1746

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

shubhamkmr04
Copy link
Contributor

Fixes: #1731
This PR addresses a bug where the isValid state was not being reset to true when a correct value of address was entered after an error.

@myxmaster
Copy link
Contributor

I think we don't need a try/catch as of line 296, what do you think? If handleAnything provides a response, then it should be good.

@myxmaster
Copy link
Contributor

But I just tested, issue is fixed! 👍

@kaloudis kaloudis merged commit 7b1c4f1 into ZeusLN:master Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send view: Error can be displayed although input was valid
3 participants