Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size/alignment of icons more consistent throughout the app #1814

Merged

Conversation

myxmaster
Copy link
Contributor

Description

  • Elements in WalletHeader usually have PaddingRight=15, so I reduced PaddingRight for LoadingIndicator here as well from 20 to 15 to make it consistent.
  • LoadingIndicator, Clipboard icon, Scan icon are now all height=35px and consistent with Settings icon.

Before:
grafik

After:
grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@myxmaster myxmaster changed the title Reduce PaddingRight for LoadingIndicator Reduce PaddingRight for LoadingIndicator, make size of icons consistent Nov 1, 2023
@myxmaster myxmaster force-pushed the loading_indicator_reduce_padding_right branch 2 times, most recently from 6979713 to 1c03244 Compare November 2, 2023 00:02
@myxmaster myxmaster changed the title Reduce PaddingRight for LoadingIndicator, make size of icons consistent Size/alignment of icons more consistent throughout the app Nov 2, 2023
@myxmaster
Copy link
Contributor Author

myxmaster commented Nov 2, 2023

Some more improvements.

Before | After

icons-01

@myxmaster myxmaster force-pushed the loading_indicator_reduce_padding_right branch from 1c03244 to 89c3740 Compare November 2, 2023 00:34
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on aligning icons, but I have mixed thoughts about changing some of these icon sizes. Let's ask @kaloudis what he thinks about it.

@kaloudis
Copy link
Contributor

kaloudis commented Nov 2, 2023

Excellent work on aligning icons, but I have mixed thoughts about changing some of these icon sizes. Let's ask @kaloudis what he thinks about it.

Thanks for checking. I gave mix the OK on this. I think these changes make the UI a bit easier to navigate.

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit e6f84c4 into ZeusLN:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants