Send: Confirm before proceeding to the address #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but while typing we don't need the text 'Must be a valid Lightning payment request, Bitcoin address, keysend address (if enabled)' below the input. It should only be displayed together with the error in case user tries to proceed but input was not valid. |
shubhamkmr04
force-pushed
the
shubham/confirm-to-validate-address
branch
from
2d678b3
to
f9a822c
Compare
|
@myxmaster please have a look again. |
|
Perfect :) |
|
What happens if you hit proceed and it can't load the address data? |
We get this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This relates to issue: #1811
We added a
Proceedbutton on the Send screen, so we will have to tap it to confirm before going with the entered address