Replace button "Show" with Icon to show/hide passphrase

[myxmaster]

Description

This fixes #1758.

Button "Show" is replaced with eye icon to show/hide passphrase at login. Implemented same logic for PIN (was missing completely). On PIN screen eye icon won't be displayed when no digit was entered yet.

Before:

After:

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

This looks pretty, pretty good

[shubhamkmr04]

Screen.Recording.2023-11-03.at.11.17.40.AM.mov

The pin slightly shifts to the left when we tap the Eye icon to show it.
Happens only in the IOS

[shubhamkmr04]

While setting and logging in through the password, the padding inside the input box seems so congested that we might need to refactor it. Also, we should have the Eye icon in this view as well.
The padding issue can be handled in the other PR as well for now.

[shubhamkmr04]

The delete button on the SetPassword view should not have the "red" color; it should have the configuration like color: themeColor('delete'), also probably add the confirmation before deleting it as well like we do in the Contacts and Nodes view

[myxmaster]

The pin slightly shifts to the left when we tap the Eye icon to show it.
Happens only in the IOS

Unfortunately I cannot test iOS. If you can find a solution to this, that would be awesome!

Also, we should have the Eye icon in this view as well.

When you have a second input for confirming, you generally don't need to show the password. It is usually either confirm by 2nd input, or show/hide.

The padding issue can be handled in the other PR as well for now.

Yeah, I think padding is something that we can improve on many places throughout the app.

The delete button on the SetPassword view should not have the "red" color; it should have the configuration like color: themeColor('delete'), also probably add the confirmation before deleting it as well like we do in the Contacts and Nodes view

Good idea, will do that! (Edit: in a different PR though)

[shubhamkmr04]

Unfortunately I cannot test iOS. If you can find a solution to this, that would be awesome!

Sure. will try to check what's going on in the ios

When you have a second input for confirming, you generally don't need to show the password. It is usually either confirm by 2nd input, or show/hide.

Okay, sounds right.

[shubhamkmr04]

tACK