Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS PAY optimizations #1888

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Nov 30, 2023

Description

This PR adds a number of optimizations to ZEUS PAY:

  • Attestation button is now a component and added to the invoice view where applicable
  • Activity filter now adds a filter for ZEUS PAY (only visible if a lightning address is registered)
  • Old preimages are deleted from the map as they're redeemed
  • msat amounts are now allowed on LND backends to ensure full amounts are redeemed (also helps with Attestation calculation)
  • The settled tab on the ZEUS PAY view is removed. This will accompany an API change that will lead to better performance.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis marked this pull request as ready for review November 30, 2023 05:08
@kaloudis kaloudis merged commit 8f05d1c into ZeusLN:master Nov 30, 2023
3 checks passed
@kaloudis kaloudis deleted the zeus-pay-optimizations branch November 30, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant