Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts V2: Implementing Nostr contacts #1907

Merged
merged 7 commits into from
Dec 26, 2023
Merged

Contacts V2: Implementing Nostr contacts #1907

merged 7 commits into from
Dec 26, 2023

Conversation

shubhamkmr04
Copy link
Contributor

No description provided.

@shubhamkmr04 shubhamkmr04 marked this pull request as draft December 13, 2023 13:05
kaloudis
kaloudis reviewed Dec 14, 2023
View reviewed changes
locales/en.json Outdated
"views.NostrContacts.NostrContacts": "Nostr Contacts",
"views.NostrContacts.LookUpContacts": "Look up Contacts",
"views.NostrContacts.ImportAllContacts": "Import all Contacts",
"views.ContactDetails.AddToTheContacts": "Add to the Contacts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this one Save to contacts

kaloudis
kaloudis reviewed Dec 14, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 14, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
@kaloudis kaloudis added this to the v0.8.1 milestone Dec 15, 2023
@kaloudis
Copy link
Contributor

We need to do validation on the npub input form

kaloudis
kaloudis reviewed Dec 18, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
@kaloudis
Copy link
Contributor

I also noticed that npubs are not being saved to profiles

@kaloudis kaloudis changed the title Contacts V2: Implementing NOSTR Contacts Contacts V2: Implementing Nostr contacts Dec 19, 2023
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
locales/en.json Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
kaloudis
kaloudis reviewed Dec 20, 2023
View reviewed changes
views/NostrContacts.tsx Outdated Show resolved Hide resolved
@kaloudis kaloudis marked this pull request as ready for review December 21, 2023 16:05
kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx Outdated
}}
rightComponent={
<Row>
{this.state.contactsData.length > 0 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contactsData var is available on line 428

kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx Outdated
transform: [{ translateX: slideInRight }]
}}
>
<CheckBox checked={isSelected} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkbox here should also trigger the toggleContactSelection func

kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx Outdated
fontSize: 16
}}
>
Enter npub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be localized

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/ContactsV2 branch 2 times, most recently from 16e0f09 to 1efd438 Compare December 21, 2023 17:48
kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx
<SelectButton />
<Icon
onPress={() => {
this.setState({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isValidNpub should also be set to false when the clear button is hit

kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx Outdated
console.log('Error importing contacts:', error);
Alert.alert(
'Error',
'Failed to import contacts. Please try again.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be localized

kaloudis
kaloudis reviewed Dec 21, 2023
View reviewed changes
views/NostrContacts.tsx Outdated
console.log('Error importing contacts:', error);
Alert.alert(
'Error',
'Failed to import contacts. Please try again.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

kaloudis
kaloudis approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit a96b347 into ZeusLN:master Dec 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaloudis kaloudis kaloudis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shubhamkmr04 @kaloudis