Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP support for LND REST #1921

Merged
merged 5 commits into from
Feb 27, 2024
Merged

LSP support for LND REST #1921

merged 5 commits into from
Feb 27, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Dec 26, 2023

Adds support for LND REST connections to leverage LSPs. If the node and connection are not configured properly to use the LSP, then users will be informed what they need to update in their configuration.

Simulator Screenshot - iPhone 15 Pro - 2024-01-19 at 17 42 57

TODO

  • Finish testing
  • Disable LSP if not configured properly
  • Refactor

@kaloudis kaloudis added this to the v0.8.2 milestone Jan 19, 2024
@kaloudis kaloudis changed the title WIP: LSP support for LND REST LSP support for LND REST Jan 19, 2024
@kaloudis kaloudis marked this pull request as ready for review February 19, 2024 02:26
@@ -121,7 +121,8 @@ export default class InvoicesStore {
ampInvoice?: boolean,
routeHints?: boolean,
addressType?: string,
customPreimage?: string
customPreimage?: string,
noLsp?: boolean
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noLsp is an override for the LSP. Can we come up w a better var name or this ok?

@kaloudis kaloudis force-pushed the lsp-lnd-rest branch 2 times, most recently from 4a15675 to d18c10c Compare February 19, 2024 02:31
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1709026349
I assume tapping on ENABLE CERTIFICATE VERIFICATION should take us to Node Configuration view instead of Nodes view

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 43a3618 into ZeusLN:master Feb 27, 2024
3 checks passed
@kaloudis kaloudis deleted the lsp-lnd-rest branch February 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants