Add functionality to share Contact via QR code #1924

shubhamkmr04 · 2023-12-28T11:21:01Z

No description provided.

components/CollapsedQR.tsx

utils/handleAnything.ts

kaloudis · 2024-01-05T16:54:24Z

Looking pretty good right now. Are there any backwards compatibility issues we created moving from id to contactId?

shubhamkmr04 · 2024-01-06T03:32:12Z

Looking pretty good right now. Are there any backwards compatibility issues we created moving from id to contactId?

Not in my opinion. Tested all features of contacts after this change

kaloudis · 2024-01-06T16:58:05Z

I found some breaking changes moving from id to contactId. You need to either add checks that moves the id to contactId on the contacts or find a different approach here. I think using a zeuscontact: or lncontact: prefix instead will be a better approach.

To see the bug, create contacts with beta2 then switch to this branch. Then try to load a contact. It will crash trying to load the banner because the contact hasn't been loaded at all. If you want to keep those old approach you need changes on Contacts.tsx and ContactDetails.tsx.

Furthermore, the other QRs are still missing prefixes. there should be nostr:, lightning:, and bitcoin: prefixes on the QRs where applicable

…sses

…edit remote contacts before saving + layout fix in AddContact

utils/handleAnything.ts

kaloudis · 2024-01-12T05:04:14Z

let's add more spacing between favorite and qr code here

views/ContactDetails.tsx

kaloudis · 2024-01-12T05:36:14Z

views/ContactInfo.tsx

@@ -0,0 +1,167 @@
+import React, { useEffect, useState } from 'react';


I don't like the name of this file ContactInfo can be confused with ContactDetails - something like ContactQRs would be more specific, more appropriate

However, I'm unsure if we're better off transforming the QR view and modifying it to handle multiple QRs than creating a new one here

I'll convert the name to ContactQR. Would that be okay? And that's a great idea to change the QR view. It definitely might be helpful!

views/ContactDetails.tsx

kaloudis · 2024-01-12T14:38:31Z

views/ContactInfo.tsx

@@ -14,15 +14,15 @@ import Header from '../components/Header';
 import { themeColor } from '../utils/ThemeUtils';


you can delete this file now

kaloudis · 2024-01-12T14:38:41Z

views/ContactQR.tsx

+
+interface IntroProps {
+    navigation: any;
+}


you don't need this second interface

Add functionality to share Contact via QR code

71fe896

shubhamkmr04 force-pushed the shubham/Contact_sharing branch 2 times, most recently from 490c0a4 to d6881d8 Compare January 3, 2024 14:18

kaloudis reviewed Jan 3, 2024

View reviewed changes

components/CollapsedQR.tsx Outdated Show resolved Hide resolved

kaloudis reviewed Jan 3, 2024

View reviewed changes

utils/handleAnything.ts Outdated Show resolved Hide resolved

Adding QR codes for all addresses of a contact

09e5474

shubhamkmr04 force-pushed the shubham/Contact_sharing branch from d6881d8 to 09e5474 Compare January 4, 2024 06:39

Change 'id' to 'contactId' in Contacts object

01656c5

handle cases for both contactId and id + adding prefixes to the addre…

9a186e4

…sses

shubhamkmr04 force-pushed the shubham/Contact_sharing branch from 3c029a9 to 9a186e4 Compare January 8, 2024 12:59

Set prefix for whole contact + exclude pictures for local contacts + …

9143394

…edit remote contacts before saving + layout fix in AddContact