Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS: Order: clearly display per unit + total values #1967

Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 31, 2024

Description

Currently the order view in the POS only displays the single unit price for each item, even if there are multiple of the same item listed on an order.

This PR clearly displays the total and single unit values of each item on the bill.

Before:
Simulator Screenshot - iPhone 15 Pro Max - 2024-01-30 at 19 21 19

After:
Simulator Screenshot - iPhone 15 Pro Max - 2024-01-30 at 19 45 54

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor Author

kaloudis commented Jan 31, 2024

One thing I'd like to address, additionally, is the line break. Need to address the KeyValue component

UPDATE: addressed in 9c8257c

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 5c6b75f into ZeusLN:master Feb 2, 2024
3 checks passed
@kaloudis kaloudis deleted the pos-order-unit-vs-total-display-value branch February 2, 2024 04:16
@kaloudis kaloudis added this to the v0.8.2 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants