Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending Lightning: Success: display preimage #1970

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Feb 2, 2024

Description

When completing a payment, display the payment preimage instead of the payment hash, if possible. The preimage has some caveats in being used as a receipt but functions better than the payment hash.

Before:
Simulator Screenshot - iPhone 15 Pro Max - 2024-02-01 at 23 49 32

After:
Simulator Screenshot - iPhone 15 Pro Max - 2024-02-01 at 23 46 32

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.8.2 milestone Feb 2, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 15 Plus - 2024-02-02 at 19 47 18
Getting this while trying to pay lightning addresses

@kaloudis
Copy link
Contributor Author

kaloudis commented Feb 2, 2024

Simulator Screenshot - iPhone 15 Plus - 2024-02-02 at 19 47 18 Getting this while trying to pay lightning addresses

which backend are you using?

@shubhamkmr04
Copy link
Contributor

Simulator Screenshot - iPhone 15 Plus - 2024-02-02 at 19 47 18 Getting this while trying to pay lightning addresses

which backend are you using?

LNDHub

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfect for LND REST

@kaloudis
Copy link
Contributor Author

kaloudis commented Feb 5, 2024

@shubhamkmr04 added some handling for LNDHub and null preimages in general.

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 1fa1fef into ZeusLN:master Feb 13, 2024
3 checks passed
@kaloudis kaloudis deleted the payment-success-preimage branch February 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants