Custom pictures for node config

[shubhamkmr04]

No description provided.

[kaloudis]

We have some conflicts

[kaloudis]

I think we can go smaller with the image sizes. Should probably still look good at a quarter of the size I think

[shubhamkmr04]

I think we can go smaller with the image sizes. Should probably still look good at a quarter of the size I think

Reduced it by 30%, we'll have to compromise the quality if we shrink the size more than this

[kaloudis]

When you change the node picture, it doesn't change the state on the NodeConfiguration page as not saved, like it would be if you changed one of the fields.

Other than that I think it's looking good

[shubhamkmr04]

When you change the node picture, it doesn't change the state on the NodeConfiguration page as not saved, like it would be if you changed one of the fields.

Other than that I think it's looking good

I think we are changing state after coming to NodeConfiguration view in InitProps function line 327 and 343

[myxmaster]

Nice PR! A few ideas/general feedback:

1. This should be fixed (happens when list of default images are displayed):
   VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead.

2. When you pick an image and click button "SET PICTURE", it is not really set, because you still need to click on next button "SAVE NODE CONFIG". I think it should be all done after clicking the first button (set picture). (Or if you don't like that idea, maybe rename "SET PICTURE" to "CHOOSE PICTURE", because you are not really setting it here.)

3. When an image for a node was already set, then you go to settings again and click on that image, it is removed and the "+" icon is displayed (and the explainer "For now, the Embedded LND nodes cannot be deleted..." is gone!). I would expect to be able to just pick another image, when I click on it.

4. When an image is already set, it is not exactly intuitive that you can actually click on the node image in node settings to change it. This is especially problematic in case Zeus picks images automatically when configuring a new node in the future (e.g. LND image for LND nodes). I think many users will not be aware they can change it. Not sure how to solve this nicely, but I guess we need some kind of "Edit node image" label.

5. When there is PIN/passphrase configured and you pick an image from gallery, Zeus will ask for PIN/passphrase when you are back in Zeus and after logging in you are back in default view -> you cannot set the node image.

6. I think it is a lot of Zeus images, maybe there should be categories which users can expand/collapse.

[shubhamkmr04]

Nice PR! A few ideas/general feedback:

1. This should be fixed (happens when list of default images are displayed):
   VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead.
2. When you pick an image and click button "SET PICTURE", it is not really set, because you still need to click on next button "SAVE NODE CONFIG". I think it should be all done after clicking the first button (set picture). (Or if you don't like that idea, maybe rename "SET PICTURE" to "CHOOSE PICTURE", because you are not really setting it here.)
3. When an image for a node was already set, then you go to settings again and click on that image, it is removed and the "+" icon is displayed (and the explainer "For now, the Embedded LND nodes cannot be deleted..." is gone!). I would expect to be able to just pick another image, when I click on it.
4. When an image is already set, it is not exactly intuitive that you can actually click on the node image in node settings to change it. This is especially problematic in case Zeus picks images automatically when configuring a new node in the future (e.g. LND image for LND nodes). I think many users will not be aware they can change it. Not sure how to solve this nicely, but I guess we need some kind of "Edit node image" label.
5. When there is PIN/passphrase configured and you pick an image from gallery, Zeus will ask for PIN/passphrase when you are back in Zeus and after logging in you are back in default view -> you cannot set the node image.
6. I think it is a lot of Zeus images, maybe there should be categories which users can expand/collapse.

Thanks for the detailed feedback! After a discussion with @kaloudis, I have updated the name to 'Choose Picture'. We will address the remaining points outlined in the feedback through subsequent PRs.

[kaloudis]

5. When there is PIN/passphrase configured and you pick an image from gallery, Zeus will ask for PIN/passphrase when you are back in Zeus and after logging in you are back in default view -> you cannot set the node image.

Related issue here #1880

[kaloudis]

4. When an image is already set, it is not exactly intuitive that you can actually click on the node image in node settings to change it. This is especially problematic in case Zeus picks images automatically when configuring a new node in the future (e.g. LND image for LND nodes). I think many users will not be aware they can change it. Not sure how to solve this nicely, but I guess we need some kind of "Edit node image" label.

I was thinking a red circle and - in the top right corner of the image to remove it, but it would likely be too small. Might need to pull in a designer for this one